fix "make format-pins" for windows#28094
fix "make format-pins" for windows#28094thinkyhead merged 6 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
8c5c46f to
1858ed1
Compare
1858ed1 to
768fd8c
Compare
c146d6e to
5373a25
Compare
|
@ellensp regarding format-pins there is a problem with the makefile in windows anyway, as line 29 has double quotes that the SO doesn't like and will not run as it is |
|
line 29 |
|
Sorry, just to clarify, ignore the line/quotes I said, the output of the command is: |
|
Although I agree its poorly formatted. It works on my test windows 11 machine without errors... After fighting with windows for several hours I've given up on using windows cmd line tools and used python to bypass all of the window weirdness with finding the required files Since I cannot replicate your make error, please test https://github.com/ellensp/Marlin/tree/update-makefile If it also works for you, ill make the pr non draft. |
Description
While helping out with #28089 it was noticed that github CI test advised to run make format-pins to clean up the pins file.
But this does not work under windows.
Updated Makefile so format pins works on linux and windows.
pinsformat.py also had to be updated slightly to stop windows converting everything to CRLF
Requirements
Windows and a desire to run make format-pins
Benefits
make format-pins now works on windows
Related Issues